Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi-types: better autocomplete with ParamsObject in v3 #883

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbnoblot
Copy link

@jbnoblot jbnoblot commented Aug 2, 2023

Hello,

I find this improvement, it can be use for v3_1,
I am inspired about https://www.sheshbabu.com/posts/rust-for-javascript-developers-pattern-matching-and-enums/

What do you think ?

Note: This checklist isn't meant to show up on the actual Pull Request (PR). It is added here to make you aware of items our maintainers will look for when reviewing your PR. If your PR is missing any of these items it will be rejected! Please delete this message and the following checklist and replace it with your own message as you see fit.

  • I only have 1 commit.
  • My commit is prefixed with the relevant package (e.g. express-openapi: fixing something) Note: You can use the bin/commit script to automate this.
  • [-] I have added tests.
  • I'm using the latest code from the master branch and there are no conflicts on my branch.
  • [-] I have added a suffix to my commit message that will close any existing issue my PR addresses (e.g. openapi-jsonschema-parameters: Adding examples to the validation keywords (fixes #455)).
  • My tests pass locally.
  • I have run linting against my code.

@jbnoblot jbnoblot marked this pull request as ready for review August 3, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant